search

MDU-PHL / pango-collapse

app to collapse Pango lineages for reporting
https://mdu-phl.github.io/pango-collapse/
GNU General Public License v3.0
10 stars 1 forks source link

Python >= 3.8 #5

Closed esteinig closed 1 year ago

esteinig commented 1 year ago

@Wytamma

@ammaraziz made me aware of these opaque pandas indexing rules:

https://towardsdatascience.com/a-solution-for-inconsistencies-in-indexing-operations-in-pandas-b76e10719744

I would like to update our dependencies to pandas >= 1.5 - which standardizes these view rules - but it depends on Python >= 3.8 and produces a conflict with pango-collapse which allows Python 3.7.

PR updates to Python >= 3.8 and pandas >= 1.5

Tests succeed with the updated dependencies in this pull request, but wasn't sure if that interferes with your backend. If you accept this PR, could you also update the pip package to latest release for our dependencies?

Wytamma commented 1 year ago

Hey @esteinig!

Sorry didn't see this one. Sounds okay... is it alright if I put a cap on pandas if i just extend the range of valid pandas versions? e.g. >=1.3,<=1.5.3? Then 1.5.3 will be favoured but will allow used with Python < 3.8 to sill use pango-collapse

esteinig commented 1 year ago

Yeah awesome, sorry for the trouble - just a caution on our end. Thanks heaps!