search

MDeLuise / plant-it

🪴 Self-hosted, open source gardening companion app
https://plant-it.org
GNU General Public License v3.0
545 stars 19 forks source link

Typo in `TRAFLE_KEY` parameter #17

Closed MDeLuise closed 8 months ago

MDeLuise commented 11 months ago

Avoid duplicated bug reports

Description

The TRAFLE_KEY parameter should be named TREFLE_KEY since the service that use that key is called trefle and not trafle.

Expected behaviour

No response

Steps to reproduce

No response

Additional info

It has to be chosen if create a breaking change with the previous commits or if achieve this in a backward compatible manner (maybe creating 2 parameters with the same name?)

cesarblancg commented 10 months ago

I think that in the early stage, it's fine to have breaking changes

MDeLuise commented 10 months ago

Thanks for the feedback I agree with you, I think that the rename of the variable could be done anytime for now, but it would be better to do in the first official release of the project, since it will be a milestone and thus breaking changes are more acceptable