MDeLuise / plant-it

🪴 Self-hosted, open source gardening companion app
https://plant-it.org
GNU General Public License v3.0
545 stars 19 forks source link

Possibility to change thumbnail picture when plant added from search feature. #61

Closed tiritibambix closed 8 months ago

tiritibambix commented 10 months ago

Avoid duplicated feature requests

Description

When I add a plant I found using the search feature, I can't edit the thumbnail picture.

It is possible when the plant is added as "custom" though.

Solution

Would be nice to use the search feature to use as a template and then edit the info including thumbnail.

What are alternatives?

No response

Additional context

From search function, maybe like in the "custom" window and as in this example :

plantit.jpg

MDeLuise commented 10 months ago

Thanks for the feedback Recently I introduced the possibility of changing the plant's avatar, but you're right, right now there is no possibility of changing the thumbnail of a species (unless it's a custom one). I think it's a good idea, it could be added directly in the "scientific classification" section of one plant of the species, and/or in the "add plant" section (as you pointed out, similar to what is done now for the custom species).

MDeLuise commented 8 months ago

Hi @tiritibambix, After the merge of #65 now it's possible to change the thumbnail of a species provided by Trefle. When you edit a Trefle species, a new (custom) species is created, and all plants associated with the first one are linked to the second one. So after that you will see two species: the "default" provided by Trefle and the one "created" by you.

The feature is available in the new 0.1.0 docker images of the system (please see the release note for the breaking changes before update).

If any problem occurs, please you're welcome to open a bug issue. Thanks for the feedback!

tiritibambix commented 8 months ago

Great news ! I will test this in the next few days and report back. Thanks a lot for the new feature :)

tiritibambix commented 8 months ago

~~Hello. I wanted to try this new feature, but when adding a new plant, I get the error Could not commit JPA transaction I couldn't see something related in the logs. Any idea ?~~

Nevermind. I didn't update properly.

Anyway, I think I don't understand the instructions. After adding a plant from trefle, where can I edit the thumbnail ?

MDeLuise commented 8 months ago

Hi! As for now, you have to search the related species from the "search" section, then open the species, and finally click on the "edit" button at the top right.

For example, let's say that you want to change the thumbnail of the Sedum spectabile:

  1. Open the species:
  2. Click on the edit button in the top right:

I know it's not so user friendly right now. Maybe I can add a button in the plants that leads directly to the relative species, where you can edit it.

tiritibambix commented 8 months ago

Ah yes, I didn't understand it has to be done before adding it to my collection.

Thank you for the explanation :)

Edit: but it looks like I can't change the thumbnail (avatar ?) anymore once I've added a plant to my collection. Is this normal ?

MDeLuise commented 8 months ago

but it looks like I can't change the thumbnail (avatar ?) anymore once I've added a plant to my collection. Is this normal ?

I think it should work without problems, does it give you an error message? What steps did you take?

tiritibambix commented 8 months ago

Once I have my plant saved, I go to the home screen, select saved plant, click the edit button, but I only have 3 choices, I can't upload a new image as the thumbnail:

IMG_20231210_212242

There used to be such an option.

MDeLuise commented 8 months ago

Ok perfect understood! In order to select an uploaded image as plant avatar you have to:

  1. upload an image of that plant
  2. open the image you want to set as avatar
  3. click on the "set as plant avatar" button

I know even this is not so user friendly, it would be right to have that feature in the menu you opened before. I'll enhance this. Also, I've started writing more detailed instructions for the app, and once I'm done, I'll be help out for sure.

tiritibambix commented 8 months ago

Oh yes, thank you. I guess I could have found that on my own...

Thanks for your help once again :)

MDeLuise commented 8 months ago

Glad to hear that it works fine 😁