[ENH] Add motion parameter conversion functions

ME-ICA / aroma

ICA-AROMA, as a Python package. A work in progress.

Apache License 2.0

7 stars 11 forks source link

Closed tsalo closed 3 years ago

tsalo commented 3 years ago

To do:

Changes proposed in this pull request:

Add functions to load motion parameters from different sources, including FSL, AfNI, SPM, and fMRIPrep.

eurunuela commented 3 years ago

Hey @tsalo , thank you for the PR!

I ran the integration test and it failed. Apparently, there's an issue with the np.dot() in line 317 of utils.py.

It's an issue with the dimensions of the matrix:

E ValueError: shapes (2,44) and (2,) not aligned: 44 (dim 1) != 2 (dim 0)

Did you have any issues running the code?

tsalo commented 3 years ago

@eurunuela I think that is what @vinferrer caught in #33.

eurunuela commented 3 years ago

@eurunuela I think that is what @vinferrer caught in #33.

It is, yes! We went through it together in GatherTown.

eurunuela commented 3 years ago

Hey @tsalo . I just merged this branch with main and all the tests pass on my computer.

I'm happy to merge this in once you merge with main.

Edit: we should add unit tests too.

tsalo commented 3 years ago

I will try to get the unit tests done before EOD (for me) Thursday.

EDIT: I lied. Working on it today.