search

ME-ICA / aroma

ICA-AROMA, as a Python package. A work in progress.
Apache License 2.0
7 stars 11 forks source link

Fix `testpath` and configure artifact path accordingly #53

Closed vinferrer closed 3 years ago

vinferrer commented 3 years ago

Closes #50 .

Changes proposed in this pull request:

  1. fix the testpath generated by tmp_path_factory to something similar to /tmp/pytest-0/data
  2. Ensure that store_artifacts is also pointing to that directory.
  3. Check that artifacts are accessible.
codecov-commenter commented 3 years ago

Codecov Report

Merging #53 (dd65bc8) into main (7b25510) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #53   +/-   ##
=======================================
  Coverage   56.09%   56.09%           
=======================================
  Files           7        7           
  Lines         410      410           
=======================================
  Hits          230      230           
  Misses        180      180
vinferrer commented 3 years ago

@tsalo, @eurunuela. This PR is ready for review, as you can see now the data directory is uploaded as artifact for the integration tests. I also took the liberty to correct the lintin artifact issue. Even if there is no file now in the artifacts for style check job thats because the program detects that the report file is empty because there aren't any lintin problems

vinferrer commented 3 years ago

One more thing, make sure to add the hactoberfest label before merging