search

ME-ICA / mapca

A Python implementation of the moving average principal components analysis methods from GIFT
GNU General Public License v2.0
6 stars 8 forks source link

Skip parzen_win steps if sm_window is false #18

Closed notZaki closed 3 years ago

notZaki commented 3 years ago

utils.ent_rate_sp fails if the sm_window argument is false. This PR fixes that.

Alternative fix: Remove the sm_window argument and always use the parzen windows. Currently, sm_window is set to true and I don't think users have a way of changing this setting. https://github.com/ME-ICA/mapca/blob/0d01a2b3d87a12e8f6778fbd549f8e83c05b58c1/mapca/utils.py#L253

codecov-io commented 3 years ago

Codecov Report

Merging #18 (3799d99) into main (0d01a2b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #18   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files           3        3           
  Lines         288      288           
=======================================
  Hits          264      264           
  Misses         24       24
Impacted Files Coverage Δ
mapca/utils.py 98.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d01a2b...3799d99. Read the comment docs.

tsalo commented 3 years ago

I'll leave reviewing your changes (and any changes to the core code) to @eurunuela, but this looks really good. I imagine we'll be able to circle around to it once the integration tests are up and running.