notZaki commented 3 years ago

It looks like scipy.signal.windows.parzen has the same functionality as utils._parzen_win. This PR makes the substitution.

The tests are still there to show that the replacement has the same output values. They could be removed.

This can be considered once the integration tests are up and running.

codecov-io commented 3 years ago

Codecov Report

Merging #23 (f8d1fa0) into main (67ad715) will decrease coverage by 0.36%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   92.09%   91.72%   -0.37%     
==========================================
  Files           3        3              
  Lines         291      266      -25     
==========================================
- Hits          268      244      -24     
+ Misses         23       22       -1

Impacted Files	Coverage Δ
mapca/utils.py	`99.15% <100.00%> (+0.55%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67ad715...f8d1fa0. Read the comment docs.

eurunuela commented 3 years ago

This is great. Thank you @notZaki !

eurunuela commented 3 years ago

@notZaki could you please push an empty commit to rerun the tests? Let's see if the integration test passes.

eurunuela commented 3 years ago

@tsalo are you okay with merging this PR?

tsalo commented 3 years ago

Sorry sorry. Everything looks great. Merging now.

ME-ICA / mapca

[REF] Replace parzen window function with one from scipy #23

Codecov Report