[FIX] Add dimensionality bug fix

ME-ICA / mapca

A Python implementation of the moving average principal components analysis methods from GIFT

GNU General Public License v2.0

6 stars 8 forks source link

[FIX] Add dimensionality bug fix #25

Closed eurunuela closed 3 years ago

eurunuela commented 3 years ago

Closes #16

This PR adds a missing line and replaces another one to ensure the matrix has the correct dimensions to perform the reshaping. I finally found out the issue was in mapca.py line 149.

eurunuela commented 3 years ago

Once we merge this PR I'll open one for integration tests that should help us advance with other open PRs.

eurunuela commented 3 years ago

This was closed by #26

tsalo commented 3 years ago

It looks like there are no changes associated with this PR now? Were they handled already in #26?

tsalo commented 3 years ago

Never mind!