ME-ICA / mapca

A Python implementation of the moving average principal components analysis methods from GIFT
GNU General Public License v2.0
6 stars 8 forks source link

Compute PCA with all possible components then give solution with optimal number of selected criterion #49

Closed eurunuela closed 2 years ago

eurunuela commented 2 years ago

Closes none.

This PR significantly optimizes the code to return as much info as possible for users:

eurunuela commented 2 years ago

We should cut a release after this by the way.

codecov-commenter commented 2 years ago

Codecov Report

Merging #49 (007d068) into main (e379c26) will increase coverage by 0.26%. The diff coverage is 90.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   90.00%   90.26%   +0.26%     
==========================================
  Files           3        3              
  Lines         290      298       +8     
==========================================
+ Hits          261      269       +8     
  Misses         29       29              
Impacted Files Coverage Δ
mapca/mapca.py 86.88% <90.62%> (+0.59%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e379c26...007d068. Read the comment docs.

eurunuela commented 2 years ago

Thanks!

Thank you!