Closed handwerkerd closed 1 year ago
Patch coverage: 80.00
% and project coverage change: -0.21
:warning:
Comparison is base (
45837f9
) 90.26% compared to head (feec953
) 90.06%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@eurunuela We don't have the 2 reviewer rule on mapca so, unless @tsalo wants to take a look, just confirm I can merge. We are supposed to have 2 approving reviews for https://github.com/ME-ICA/tedana/pull/951
This PR is really simple. I think 1 review is enough.
I'm still mixed on what to do with #56, but I'm realizing that PR has two parts. It both lets users set the subsampling values and it logs the estimated value. I not sure if it's worth letting users set the value, but we really want this information logged and I don't want to hold up that part. Here's a PR that just logs the info. If it looks good, I'd like to see this merged soonish. I'll open a paired PR for tedana so that the values will be stored with the tedana outputs.