Closed eurunuela closed 9 months ago
We may want to drop support for 3.5 and add tests for up to 3.10 or so.
I will open a new PR to work on the project.toml
and update the minimum Python version for the package (needs to be at least 3.8).
At least now @marco7877 can work with maPCA.
It looks like @tsalo may be busy, @handwerkerd would you mind reviewing this? It's impacting tedana for users with a newer version of scikit-learn
.
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
70aa234
) 90.96% compared to head (e89a44d
) 90.96%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@eurunuela Will we also need to update the minimum mapca version in tedana to fully address this sklearn compatibility issue? It's currently mapca>=0.0.3 and I think this will now be mapca 0.0.5.
@eurunuela Will we also need to update the minimum mapca version in tedana to fully address this sklearn compatibility issue? It's currently mapca>=0.0.3 and I think this will now be mapca 0.0.5.
Yes, as soon as we cut a release for mapca. Shall we do that at the meeting on Thursday?
With this and #64 merged, I think you can cut a release whenever you have time and then we can bump up the minimum mapca version in tedana.
Closes #58.
This PR proposes:
n_features_
forn_features_in_
to be compatibly with sklearn.