search

ME-ICA / mapca

A Python implementation of the moving average principal components analysis methods from GIFT
GNU General Public License v2.0
6 stars 8 forks source link

Set up continuous integration #7

Closed tsalo closed 3 years ago

tsalo commented 3 years ago

I copied the relevant tests from tedana over but we'll need to set up CI with workflows for the unit tests, coverage, and linting.

tsalo commented 3 years ago

We mostly just need to get codecov up and running, which will probably have to happen after we make the repo public.

eurunuela commented 3 years ago

Thanks @tsalo ! I actually opened a branch to do this and adapted the tests a bit. I also set up CircleCI.

Shall we make the repo public? For the sake of having codecov I mean. We could add a statement that this is not a package as of now because we're waiting for license.

tsalo commented 3 years ago

I saw that when I was debugging my last PR! Thanks for that!

Making the repo public sounds reasonable. It's not like it's any new code. I like the statement idea too.

tsalo commented 3 years ago

I've added a warning to the README and made the repo public. We should be able to set up codecov now.

tsalo commented 3 years ago

There must be something messed up in the CircleCI config, since the report is being sent but it's registering as having no lines covered at all.

eurunuela commented 3 years ago

There must be something messed up in the CircleCI config, since the report is being sent but it's registering as having no lines covered at all.

I'll look into that. Thanks for pointing that out.

eurunuela commented 3 years ago

We still have no coverage because the config runs commands from Makefile. I'll merge my work on the tests branch even if it's not completely finished, but that should do the trick.