ME-ICA / tedana

TE-dependent analysis of multi-echo fMRI
https://tedana.readthedocs.io
GNU Lesser General Public License v2.1
161 stars 95 forks source link

Fix error on empty input file & pre-commit updated to black version 24.2.0 #1031

Closed handwerkerd closed 7 months ago

handwerkerd commented 7 months ago

Closes #974. Closes #1007.

Changes proposed in this pull request:

tsalo commented 7 months ago

There's a linting issue, but other than that (maybe you need to update black?) it looks good to me.

handwerkerd commented 7 months ago

I think I fixed the style issue. The precommit was the issue. I upgraded to black=24.2.0 and I think that's what CircleCI is using, but the precommit was using 23.10.0 and would un-edit the style change when I tried to push the commit. I needed to update the version of black in .pre-commit-config.yaml and now it looks like the style test is passing. I'll make a note of this in the PR title

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.54%. Comparing base (6b82622) to head (e98e396). Report is 50 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1031 +/- ## ========================================== + Coverage 89.51% 89.54% +0.02% ========================================== Files 26 26 Lines 3453 3462 +9 Branches 630 632 +2 ========================================== + Hits 3091 3100 +9 Misses 210 210 Partials 152 152 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

handwerkerd commented 7 months ago

@all-contributors please add @martinezeguiluz for code

allcontributors[bot] commented 7 months ago

@handwerkerd

I've put up a pull request to add @martinezeguiluz! :tada: