ME-ICA / tedana

TE-dependent analysis of multi-echo fMRI
https://tedana.readthedocs.io
GNU Lesser General Public License v2.1
161 stars 95 forks source link

Output RMSE map and time series for decay model fit #1044

Closed tsalo closed 5 months ago

tsalo commented 7 months ago

Closes #861.

Changes proposed in this pull request:

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 94.25287% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.91%. Comparing base (af5e99a) to head (730354a). Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
tedana/decay.py 93.33% 1 Missing and 1 partial :warning:
tedana/io.py 84.61% 1 Missing and 1 partial :warning:
tedana/workflows/tedana.py 80.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1044 +/- ## ========================================== + Coverage 89.80% 89.91% +0.11% ========================================== Files 26 26 Lines 3540 3621 +81 Branches 621 629 +8 ========================================== + Hits 3179 3256 +77 - Misses 212 214 +2 - Partials 149 151 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 6 months ago

@madisoth gave me the thumbs up on this offline, so I'm opening it up for review.

tsalo commented 5 months ago

Here's the mean RMSE image for the 3-echo dataset:

Screenshot 2024-04-12 at 12 09 19 PM

Here's the timeseries plot (with +/- 1 SD) for the same dataset:

Screenshot 2024-04-12 at 12 09 30 PM
tsalo commented 5 months ago

The results are now substantially different:

Screenshot 2024-04-22 at 9 33 58 AM
handwerkerd commented 5 months ago

The results are now substantially different:

I do expect the values to be non-trivially lower because you were including voxels with 1 good echo, which meant fit coefficients of 0 (i.e. the residual error would be the entire time series).

tsalo commented 5 months ago

Ah, okay. That's a relief then.

tsalo commented 5 months ago

That's fixed in my most recent commit.

tsalo commented 5 months ago

@handwerkerd I think everything should be good now. Would you mind taking another look?

tsalo commented 5 months ago

Thanks @handwerkerd!

Here's what the updated 3-echo timeseries plot looks like, for posterity.

Screenshot 2024-04-27 at 9 33 58 AM