Closed tsalo closed 5 months ago
Attention: Patch coverage is 94.25287%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 89.91%. Comparing base (
af5e99a
) to head (730354a
). Report is 22 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@madisoth gave me the thumbs up on this offline, so I'm opening it up for review.
Here's the mean RMSE image for the 3-echo dataset:
Here's the timeseries plot (with +/- 1 SD) for the same dataset:
The results are now substantially different:
The results are now substantially different:
I do expect the values to be non-trivially lower because you were including voxels with 1 good echo, which meant fit coefficients of 0 (i.e. the residual error would be the entire time series).
Ah, okay. That's a relief then.
That's fixed in my most recent commit.
@handwerkerd I think everything should be good now. Would you mind taking another look?
Thanks @handwerkerd!
Here's what the updated 3-echo timeseries plot looks like, for posterity.
Closes #861.
Changes proposed in this pull request:
desc-confounds_timeseries.tsv
file. This removes the global signal time series file (desc-globalSignal_timeseries.tsv
).