Closed tsalo closed 2 months ago
Attention: Patch coverage is 96.55172%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 89.81%. Comparing base (
62e15ab
) to head (b5d5a17
).
Files | Patch % | Lines |
---|---|---|
tedana/workflows/tedana.py | 75.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think that's better. I noticed the figure has some blank area above and below the actual figure itself. This means that effectively, the brains are not going to be 500px in height, but the whole thing with the blank area above and below will be. I don't know where this blank area came from. It must be from the function that generates the image.
See below 👇 The blue area shows the whole <img>
component, containing the brains plus the blank areas I mentioned.
I dropped the brainplot
class and things look better. @eurunuela WDYT?
I'm working on improving the figure- the 3-echo one was looking weird.
Okay it's looking a lot better now.
Closes #1072.
Changes proposed in this pull request:
tedana.reporting.static_figures.plot_adaptive_mask
, which creates a figure showing the base mask, the denoising mask (adaptive mask >= 1), and the classification mask (adaptive mask >= 3) overlaid on top of the mean optimally combined image.