ME-ICA / tedana

TE-dependent analysis of multi-echo fMRI
https://tedana.readthedocs.io
GNU Lesser General Public License v2.1
158 stars 94 forks source link

Add adaptive mask plot to report #1073

Closed tsalo closed 2 months ago

tsalo commented 2 months ago

Closes #1072.

Changes proposed in this pull request:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.55172% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.81%. Comparing base (62e15ab) to head (b5d5a17).

Files Patch % Lines
tedana/workflows/tedana.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1073 +/- ## ========================================== + Coverage 89.74% 89.81% +0.07% ========================================== Files 26 26 Lines 3509 3536 +27 Branches 619 620 +1 ========================================== + Hits 3149 3176 +27 Misses 211 211 Partials 149 149 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

eurunuela commented 2 months ago

I think that's better. I noticed the figure has some blank area above and below the actual figure itself. This means that effectively, the brains are not going to be 500px in height, but the whole thing with the blank area above and below will be. I don't know where this blank area came from. It must be from the function that generates the image.

See below 👇 The blue area shows the whole <img> component, containing the brains plus the blank areas I mentioned.

CleanShot 2024-04-11 at 20 47 43@2x

tsalo commented 2 months ago

I dropped the brainplot class and things look better. @eurunuela WDYT?

tsalo commented 2 months ago

I'm working on improving the figure- the 3-echo one was looking weird.

tsalo commented 2 months ago

Okay it's looking a lot better now.

Screenshot 2024-04-12 at 10 55 37 AM
tsalo commented 2 months ago

@handwerkerd WDYT? https://tedana--1073.org.readthedocs.build/en/1073/outputs.html#adaptive-mask-summary-plot