ME-ICA / tedana

TE-dependent analysis of multi-echo fMRI
https://tedana.readthedocs.io
GNU Lesser General Public License v2.1
158 stars 94 forks source link

Use nearest-neighbors interpolation in `plot_component` #1098

Closed tsalo closed 1 month ago

tsalo commented 1 month ago

Closes #1095.

Changes proposed in this pull request:

tsalo commented 1 month ago

From Logan's 8-echo dataset.

Before:

image

After:

image

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.91%. Comparing base (12aea7f) to head (d8df3e6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1098 +/- ## ======================================= Coverage 89.91% 89.91% ======================================= Files 26 26 Lines 3621 3621 Branches 629 629 ======================================= Hits 3256 3256 Misses 214 214 Partials 151 151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 1 month ago

Good point. I dropped the change for plot_stat_map calls outside of plot_component.

tsalo commented 1 month ago

Yeah we'd need to use threshold instead of vmin, but I played around with that and had some issues, so I think this is fine for now. If we end up overlaying our stat maps on other images (e.g., mean OC, T1w) then we might need to revisit.

tsalo commented 1 month ago

I'd like to make a release with this change before we merging #1064. @handwerkerd any objections?