search

ME-ICA / tedana

TE-dependent analysis of multi-echo fMRI
https://tedana.readthedocs.io
GNU Lesser General Public License v2.1
161 stars 95 forks source link

Fix reference rendering in HTML report #986

Closed handwerkerd closed 8 months ago

handwerkerd commented 11 months ago

Summary

In tedana_report.html files LaTeX formatting for references are not rendering correctly.

Additional Detail

For example, see https://me-ica.github.io/ohbm-2023-multiecho/tedana/tedana_results_kundu_five-echo/tedana_report.html The raw LaTeX typesetting appears in the HTML

eurunuela commented 11 months ago

Was it always like that?

I may be wrong but something tells me this is new after #875?

handwerkerd commented 11 months ago

I just opened up some reports from May 2022 (before #875 on Aug 12, 2022) and they were rendered correctly and some reports from November 2022 were not rendered correctly. I have some in Sept 2022 which were rendered correctly, but I was messing with versions as part of decision tree modularization so I'm not sure those used the updated main as of Sept 2022. The only other merged PR in those months that could have possible changed this was #818 but I just ran the tests with Python 3.9 and it still had these rendering issues. This is a long way of saying you're probably right regarding #875.

crewalsh commented 8 months ago

@eurunuela I poked around a bit to see if there was an easy option to fix the in-text citations in the report using pybtex (or any other package), but couldn't seem to find an easy solution. Have you had time to look at this any further? I think it might be possible to fix with some regex, but didn't want to re-invent the wheel if you've already had luck with this.

eurunuela commented 8 months ago

Hey @crewalsh , I haven't had much time but I think I may be able to work on it today.