Support localization - multilanguage

ME-MarvinE / XCalendar

A plugin for .NET providing an API for representing a calendar along with fully customisable calendar controls for Xamarin Forms and .NET MAUI

MIT License

300 stars 36 forks source link

Support localization - multilanguage #158

Closed migueBarrera closed 1 year ago

migueBarrera commented 1 year ago

What do you think of this functionality?

I have added support for Spanish, English, German, French, Italian and Portuguese.

I have refactored the StringCharLimitConverter converter, I have added its text truncation functionality to the Core in StringsExtensions and I have added a Test battery. The new converter, LocalizeDayOfWeekAndCharLimitConverter, translates the name of the DayOfWeek enum into its day of the week based on the device's language.

Spanish sample screenshot: Screenshot_2023-09-04-15-33-50-984_com companyname xcalendarmauisample

migueBarrera commented 1 year ago

Thank you very much. It was a great review. Great quality. Great job.

Changes after your comments:

Recover StringCharLimitConverters
Unify logic of converters. Remove duplicate code on Xamarin.Forms and Maui.
Remove Resources and use culture.DateTimeFormat.GetDayName
Move StringsExtensionsTest to correct location from Test.Models to Test.Extensions
Refactor StringsExtensions
Add more test with new uses cases and methods

migueBarrera commented 1 year ago

You can review again :)

ME-MarvinE commented 1 year ago

Nice, I will release a new version soon since I think many people would want to have this feature as soon as possible.