search

ME1312 / SubServers-2

SubServers – The Minecraft Server Management Platform
Apache License 2.0
91 stars 23 forks source link

Memory leak? #63

Closed wysohn closed 3 years ago

wysohn commented 3 years ago

Platform Information

13:50:23 [INFO] CONSOLE executed command: /sub version 13:50:23 [INFO] SubServers > These are the platforms and versions that are running SubServers.Bungee: 13:50:23 [INFO] Linux 5.4.0-72-generic [x64], 13:50:23 [INFO] Java 11.0.11 [x64], 13:50:23 [INFO] BungeeCord git:BungeeCord-Bootstrap:1.16-R0.4-SNAPSHOT:9c078b7:1539, 13:50:23 [INFO] SubServers.Bungee v2.16.4a (20w46b) 13:50:23 [INFO] 13:50:23 [INFO] SubServers.Bungee v2.17a is available. You are 1 version behind.

Yes, I know that I'm 1 version behind, but I haven't found this issue being addressed in the latest version as well, so I'm reporting it anyway. Sorry if you already fixed it! The crash happens very rarely and without any context, so it's very hard to catch it.

What Happened

Server hard crash with OutOfMemoryError

How It Happened

It usually works fine for about 6~7 days, and it crashes

Additional Information

One instance of net.ME1312.SubData.Server.SubDataClient loaded by jdk.internal.loader.ClassLoaders$AppClassLoader @ 0x80100150 occupies 1,532,034,448 (72.98%) bytes.

Keywords

net.ME1312.SubData.Server.SubDataClient
jdk.internal.loader.ClassLoaders$AppClassLoader @ 0x80100150

Screenshot from 2021-07-03 13-59-54 Screenshot from 2021-07-03 14-00-22 Screenshot from 2021-07-03 14-00-31 Screenshot from 2021-07-03 14-00-48

I don't know why would SubDataClient have to use such a high percentage of the heap space, and I don't even utilize the SubData anyway. So I highly suspect that it is a memory leak.

Also, the data is being transferred locally, I don't really think it's something to do with denial of attack.

ME1312 commented 3 years ago

You're right on the money with this one. I received similar reports and was able to get this fixed by release (2.17). The reason it didn't make the release notes is because the problem only existed in the snapshot versions.

wysohn commented 3 years ago

You're right on the money with this one. I received similar reports and was able to get this fixed by release (2.17). The reason it didn't make the release notes is because the problem only existed in the snapshot versions.

Nice! All I have to do is updating it to the latest version then. Thanks for letting me know!