ME1312 / VanillaCord

VanillaCord – IP Forwarding support for Vanilla Minecraft Servers
Mozilla Public License 2.0
75 stars 11 forks source link

[Feature Idea] Possibility to use BungeeGuard instead of Velocity Modern Forwarding #18

Closed Mrredstone5230 closed 2 years ago

Mrredstone5230 commented 2 years ago

Everything's in the title. (I said "instead" but having both option available when patching the jar would be nice) Would it be possible?

ME1312 commented 2 years ago

Well, it looks like BungeeGuard forwarding is design-compatible with normal IP forwarding, so you should be able to login to a VanillaCord server just fine as-is. That said, some changes will be needed to actually check for and make use of the provided token.

ME1312 commented 2 years ago

As of that commit, it should now be possible to specify BungeeGuard tokens for VanillaCord to validate using seecret.txt.

seecret.txt isn't new to those using modern IP forwarding, but it is new to those using "legacy" IP forwarding. You can learn more about it by clicking the relevant link in the last sentence.

Mrredstone5230 commented 2 years ago

Do you have to directly execute Pather.class ? I don't understand how seecret.txt is supposed to be generated.

ME1312 commented 2 years ago

As "BungeeCord" and "BungeeGuard" use the same method for forwarding information, no additional patches are required – so the patch process remained the same as it was before. seecret.txt is a config file that appears after joining a VanillaCord server.

Mrredstone5230 commented 2 years ago

Unfortunately, it didn't quite work. If you but an invalid token from bungee, the player will still be able to connect. Made a quick patch for it.