search

ME3Tweaks / ME3TweaksModManager

Mod Manager for Mass Effect Original Trilogy and Mass Effect Legendary Edition
GNU General Public License v3.0
123 stars 34 forks source link

Slow disks cause issues in Installation Information panel when restoring #411

Closed Mgamerz closed 2 months ago

Mgamerz commented 4 months ago

When restoring individual files, or removing DLC mods in Installation Information, if the filesystem is taking a long time to return the file list (such as using a USB storage volume), this can cause race conditions where it duplicates the data shown in the panel. This needs to be handled to prevent issues.

Mgamerz commented 4 months ago

This issue was due to notifyDeleted() callback of DLC mod deletion method triggering an entire reload of modified data, rather than just the DLC mods list. On slow disks this could cause duplication as they'd both start and then later both finish, but the list of basegame files was only cleared at the start.