search

ME3Tweaks / ME3TweaksModManager

Mod Manager for Mass Effect Original Trilogy and Mass Effect Legendary Edition
GNU General Public License v3.0
121 stars 34 forks source link

Feature Request: debug names for LE1 in save selector dialog #426

Open DropTheSquid opened 3 weeks ago

DropTheSquid commented 3 weeks ago

I recently released a mod that adds debug saves to LE1. It works perfectly in game, and works ok with mod manager, but Mod Manager does not display the debug names when you select a specific save to boot into. Mod manager can still select a save by number and successfully boot into it.

It would be really great if this could be updated to support debug names similar to the way it does for 2/3 saves.

There are two ways to set the debug save name. First is embedded within the filename. The filename will be "CharacterId_DebugName_number.pcsav", as opposed to the usual. CharacterId_number.pcsav naming convention. Anything between the underscores is treated as the debug name by my mod.

You can also set the display name within TSE, and my mod will display that in the list if it differs from the default format. If both are present, the filename takes priority. Debug saves created with the new console command added by the mod use the filename format.

So, updating the save selector dialog to display the debug name parsed out of the filename and optionally the display name from inside the save file would be very helpful.

Mgamerz commented 3 weeks ago

Looking at values of 'DisplayName' in TSE, those are often random data, so I won't be using those. It blows up the interface as well. I am unsure if our parser is actually correct, it is based on BioWare's code, but we had other problems in it before.

image

I will only use the filename. Your mod will need to ensure that you cannot use a _ in the name or it will not show anything as I require 2 and only 2 underscores.

image

Mgamerz commented 3 weeks ago

Implemented in the latest alpha build.

DropTheSquid commented 2 weeks ago

Confirmed this is working. I think it is entirely reasonable to leave out the debug name from inside the save, since it is, as you noted, annoying gibberish by default. The game has some native code that handles that differently if it is non default, but I think it is fine to ignore it here.

I can update the mod to replace underscores within the name with spaces or something, but we can't technically prevent folks from putting extra underscores in the filename. The mod handles multiple underscores correctly. It would be even better if it handled them, but I am fine letting it gracefully fail if users go around restrictions we have put in place.

Mgamerz commented 2 weeks ago

If users manually edit filenames, I don't think it is reasonable to expect tools to work. Just like when someone changed the casing of the dlc folder names.

DropTheSquid commented 2 weeks ago

Agreed. I think this is more than good enough. I have updated the mod to replace underscores with spaces when they create the save via the mod. I consider this feature done. Thanks for implementing it.