search

MECLabTUDA / M3d-Cam

MIT License
306 stars 40 forks source link

Issue including medcam as a dependency in conda package #11

Closed sarthakpati closed 3 years ago

sarthakpati commented 3 years ago

Hey,

I am trying to install medcam as a conda dependency for GaNDLF but I am getting the following error:

pkg_resources.DistributionNotFound: The 'opencv-python' distribution was not found and is required by medcam

Which is completely legit because conda doesn't publish opencv-python (they publish opencv directly, which works with the cv2 namespace in python).

I propose to put opencv-python as an optional installation target that gets triggered when installing through pip and removing it as a dependency in the install_requires of setup.py. I can put in a PR that highlights a prototype for this.

Cheers, Sarthak

Karol-G commented 3 years ago

Thanks for the fix. I merged it 👍