Open lydon42 opened 1 year ago
I am working in the VHDL to determine why it is an issue since the feature is actually desirable but shouldn't be causing so much trouble. The problems really shouldn't be happening.
I'd like to see the default setting be off, though.
I'd like to make a note that the version merged did not include fixes after discussion with kibo.
So is here still something missing @M3wP and @ki-bo ?
I will need to investigate and look up past conversations, as I don't remember 100% anymore.
Sorry, yes. There were a few changes that @ki-bo made with me in discussion that weren't in the changes that were applied.
I've attached what I have. @lydon42, you should be able to rescue them from the attached file.
Found this while doing the Changelog.md.
Comparing this gs4510.vhdl to release-0.96 is hard, because there are a lot of changes. It seems the only thing that is really different are the parts which start with -- overflow: so saturate instead
.
I don't know if this is still an issue and needs to be fixed or if this is already fixed. Can someone check this too?
It should be largely fixed however the implementation that was taken is not the last one I had made. I made additional changes based on some conversation with kibo but they were not copied to the code base afaik.
I still have the complete changes. It is some time ago that this was done but I should be able to assist in reconstructing the code.
From: Oliver Graf @.> Sent: 24 January 2024 08:35 To: MEGA65/mega65-core @.> Cc: M3wP @.>; Mention @.> Subject: Re: [MEGA65/mega65-core] AUDIO_DMA: audio samples sound very distorted (Issue #651)
Found this while doing the Changelog.md.
Comparing this gs4510.vhdl to release-0.96 is hard, because there are a lot of changes. It seems the only thing that is really different are the parts which start with -- overflow: so saturate instead.
I don't know if this is still an issue and needs to be fixed or if this is already fixed. Can someone check this too?
— Reply to this email directly, view it on GitHubhttps://github.com/MEGA65/mega65-core/issues/651#issuecomment-1907035445, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACNUI54PDA65A5POAMMCROLYQA3MLAVCNFSM6AAAAAAUBO4OS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBXGAZTKNBUGU. You are receiving this because you were mentioned.Message ID: @.***>
Reported by deft, Bit found by M3WP
Issue #228 introduced an
audio_dma_saturation_enable
switch, which seems to be enabled by default.This apparently results in distorted audio.
Todo: