search

MEGA65 / mega65-core

MEGA65 FPGA core
Other
239 stars 84 forks source link

MEGA+SHIFT+POUND keypress should only be allowed via physical keyboard input #673

Closed ki-bo closed 6 months ago

ki-bo commented 1 year ago

Is your feature request related to a problem? Please describe. The remote network access (which can be a security risk when turned on unintentionally and/or in insecure environments) needs to be activated until the next cold start via MEGA+SHIFT+POUND. As this is a security related feature, that keypress should only be possible to trigger via physical keyboard.

Describe the solution you'd like Disable MEGA+SHIFT+POUND keypresses via synthetic key events.

gardners commented 1 year ago

See c200b92ccb0b0eaf951e218c69495971642aa305

It turns out I made it just SHIFT+POUND with this commit.

gardners commented 1 year ago

Confirmed working with SHIFT+POUND on this commit.

ki-bo commented 11 months ago

Could we change this to be CTRL+'+' or CTRL+'-'? These two don't seem to have any effect in BASIC, while SHIFT+POUND and MEGA+SHIFT+POUND are actually provide keyboard input to BASIC resulting in character output.

lydon42 commented 6 months ago

We keep SHIFT-POUND for batch 3 and discuss possible more complex security changes afterwards.

lydon42 commented 6 months ago

This stays as it is for the release.