search

MEGA65 / mega65-core

MEGA65 FPGA core
Other
239 stars 84 forks source link

Wrong right border position with H640 disabled #681

Closed ki-bo closed 1 year ago

ki-bo commented 1 year ago

Test Environment (required)

Describe the bug The right border is drawn one pixel too early in H320 mode, cutting off one physical pixel (half a logical 320 pixel). It can be concluded that the drawn screen area is only 639 physical pixels when H640 is off.

To Reproduce Steps to reproduce the behavior:

  1. Fill the right column with characters and inspect their drawn pixel representation closely
  2. When using ESC 4 and ESC 8 repeatedly, one can observe the right border move between those two modes

Expected behavior The right border position shall be the same with H640 on and off. The visible screen area shall be 640 pixels wide by default (not 639 pixels).

Screenshots See screenshot attached, the letters are slightly narrower than expected (3px instead of 4 on the right side)

IMG_0464

ki-bo commented 1 year ago

No dedicated test case needed as test for #682 is already covering this case, as well.