MEGA65 / mega65-core

MEGA65 FPGA core
Other
241 stars 88 forks source link

Right most character pixel not drawn with H640 disabled #682

Closed ki-bo closed 1 year ago

ki-bo commented 1 year ago

Test Environment (required)

Describe the bug When disabling H640 mode (eg. pressing ESC 4 to enable 40 col mode), the rightmost pixel of the last character column is not drawn anymore. This was hidden by bug #681 up until now, as that one was moving the right border wrongly one pixel left into the last character. If #681 is corrected, it gets apparent that the last logical pixel is only drawn halfway.

The issue does not show when H640 is enabled.

To Reproduce Steps to reproduce the behavior:

  1. Switch to 40 col mode (ESC 4)
  2. Move the border one pixel to the outside (or use a core that fixes #681 already) - can be done in matrix monitor by s777d05c 4f
  3. Observe last pixel drawn on the right side - there will be a gap with background color between the last pixel and the border

Expected behavior All 640 pixels drawn with character data when H640 is disabled. No gap between rightmost character pixel and right border.

Screenshots See attached screenshot. Note the gap and also the narrow M and W characters on the right side.

IMG_0463