search

MEGA65 / mega65-core

MEGA65 FPGA core
Other
237 stars 84 forks source link

Thumbnails are blank in freezer #757

Closed gardners closed 3 days ago

gardners commented 6 months ago

Test Environment (required) Head of development as of 17DEC2023 running on any MEGA65 board. I can reproduce it on an R5 board.

Describe the bug Thumbnail area appears blank in freeze menu

To Reproduce

  1. Boot MEGA65
  2. Long-press RESTORE to enter freeze menu
  3. Note that thumbnail shows all black (or some other constant colour).

Expected behavior Thumbnail shows a mini-display of the frozen state.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context

From @Johnwayner in discord: It appears that the addressing changes in https://builder.mega65.org/job/mega65-core/job/development/17/ broke the ability of the freeze code to read from the thumbnail generator addresses at $FFD2640 and $FFD2641. Thus the freezer is just reading some memory somewhere else. My VHDL is very weak. <@824166878284349461> might be able to help with this as he was involved with these changes.

This will narrow it down quite a bit.

gardners commented 6 months ago

Confirmed that mega65-tools/src/tests/thumbnail.a65 still displays the thumbnail. It is only the freezing process that doesn't work.

thumbnail.a65 uses $D640 in M65 IO memory map, i.e., effectively using $FFD3640.

HYPPO is currently uses $FFD2640.

That should be ok, though, as $FFD2640 should also have the thumbnail mapped there.

Just confirmed that $FFD2640 also works, by reading it from BASIC65.

So the problem seems to be it not being accessible from Hypervisor memory context.

dansanderson commented 3 days ago

I believe this is fully fixed as of release v0.96. This can be closed.