Closed zeldin closed 1 month ago
Isn't that more simple to use mkdir -p
which won't fail when a directory already exist? Then there is no even need for testing if the directory already exists just mkdir -p work
unconditionally.
Sure, that would work as well.
I have now managed to build xmega65 for Linux/PPC64 (this turned out to be super easy, kudos!), so all the tests have been run.
I also ran the mkdir -p
version through the tests and that passed as well. Let me know if you prefer that version and I'll just force push this PR.
Two or more threads could all at the same time test that the "work" directory did not exist and then each proceed to create it, with all but one failing. By making it an ordering dependency, this is prevented from happening.
Checklist
Thanks a lot for your contribution! Please tick off the following:
make test
)clang-format -i <file>
Note: I did not change any code, just the
Makefile
. I can't runmake test
currently because I don't havexmega65
. Getting that to run is probably a separate adventure. :smile: