MEGA65 / mega65-tools

Tools and Utilities for the MEGA65 Retro Computers
GNU General Public License v3.0
29 stars 31 forks source link

MEGAFLASH: megaflash.c seems to still be using slot sizes of 4MB #13

Closed gurcei closed 3 years ago

gurcei commented 3 years ago

Taking a look at "megaflash.c" - reflash_slot():

https://github.com/MEGA65/mega65-tools/blob/9fa741233a3ef49b6b8175b1b53e230e87d90b51/src/utilities/megaflash.c#L526

It appears that the code here still thinks it is dealing with 4MB-sized slots.

Paul suggests that it needs to check the FPGA version tag in the bitstream.

For more detailed thoughts on the convo that led to this card: https://discord.com/channels/719326990221574164/791383472853614593/802163436762300456

gurcei commented 3 years ago

After further inspection tonight, this appeared to be viewing an older copy of 'megaflash.c' that resided in the mega65-tools repo.

The latest/active copy of 'megaflash.c' actually resides in the 'mega65-core' repo.

So I have removed the old/unused copy of 'megaflash.c' in work done on card #12.

I'll proceed to close this card now.