search

MEGA65 / mega65-tools

Tools and Utilities for the MEGA65 Retro Computers
GNU General Public License v3.0
28 stars 31 forks source link

Give all functions in remotesd_eth.c proper ANSI prototypes #195

Closed zeldin closed 3 weeks ago

zeldin commented 3 weeks ago

This fixes the build with cc65 V2.17.

lydon42 commented 3 weeks ago

Please use the cc65 commit the submodule is locked to for testing.

zeldin commented 3 weeks ago

Before my change it only worked without USE_LOCAL_CC65=1 (i.e. when using the submodule). After my change it works with both USE_LOCAL_CC65=1 and with the one in the submodule (79018fd424bcf64533f82a19167f25b5fc02d1de).

zeldin commented 3 weeks ago

(I normally use the cc65 in the submodule, but I wanted to check the dependency fix with USE_LOCAL_CC65=1 as well. :smile:

lydon42 commented 3 weeks ago

Our docker build environment (MEGA65/builder-docker) has exactly that cc65 as local installation. Reason is that later commits produce larger code, which makes some of the internal tools to big to be incorporated. But we will be moving away from cc65 soon, as it as seems to be inferior solution. We will either move to llvm-mos (better code generation) or Calypsi (native 45GS02 code generation).

lydon42 commented 3 weeks ago

Btw: drop by on out discord. Or if you already there, give me a ping...

zeldin commented 3 weeks ago

Well, I don't interface all that well with discord... I don't suppose you have an IRC channel?

zeldin commented 3 weeks ago

Once there is a discord client for the Mega65 I may reconsider. :laughing:

lydon42 commented 3 weeks ago

Oh, there is a IRC client for the MEGA65? I didn't know that! ;)

zeldin commented 3 weeks ago

If there isn't one already I may make one once I get my Mega65...