search

MEGA65 / mega65-tools

Tools and Utilities for the MEGA65 Retro Computers
GNU General Public License v3.0
29 stars 31 forks source link

ROMDIFF: Compiler warnings SNPRINTF overflow #55

Closed Edilbert closed 2 years ago

Edilbert commented 3 years ago

17:02 1076 /Users/home/MEGA65/C65/tools cc -o romdiff romdiff.c romdiff.c:369:3: warning: 'snprintf' will always overflow; destination buffer has size 224, but size argument is 256 [-Wbuiltin-memcpy-chk-size] snprintf((char)&header[32], 256, "%s", normalise(argv[1])); ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/secure/_stdio.h:57:3: note: expanded from macro 'snprintf' builtin___snprintf_chk (str, len, 0, darwin_obsz(str), __VA_ARGS__) ^ romdiff.c:370:3: warning: 'snprintf' will always overflow; destination buffer has size 160, but size argument is 256 [-Wbuiltin-memcpy-chk-size] snprintf((char)&header[32 + 64], 256, "%s", normalise(argv[2])); ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/secure/_stdio.h:57:3: note: expanded from macro 'snprintf' builtin___snprintf_chk (str, len, 0, darwin_obsz(str), __VA_ARGS__) ^ 2 warnings generated.

lydon42 commented 2 years ago

Fixed in d373f4c0510f6d9a2c8714cb0516dee7bc650a09