MEN-Mikro-Elektronik / 13MD05-90

MDIS5 System Package for Linux (including drivers)
Other
4 stars 4 forks source link

SC31 - smb2 tools are not build #214

Closed M-Gerner closed 3 years ago

M-Gerner commented 3 years ago

When installing MDIS5 on a system with a SC31 (BC51M, DC19) the smb2 tools (smb2_eetemp, etc.) were not build. The driver is installed sucessfully.

The customer was able to find a way to solve the issue for himself through modifying the makefile. They copied two lines from F011 to SC31 (see pictures). grafik grafik

dpfeuffer commented 3 years ago

... through modifying the makefile.

The code above is from the scan_system.sh script, but not from a makefile.

... copied two lines

The line add_xm01bc_support is not required to build the smb2_* tools.

We have to clarify: 1) Does the SC31 has a XM01BC board controller? 2) For which CPU boards (SC31, SC24, SC25, ...) should we add the SMB2 tools?

M-Gerner commented 3 years ago

I have double checked it with a SC24, SC31 and JPE Dev Branch.

On both (SC24 and SC31) the drivers (men_ll_smb2, men_ll_xm01bc) and xm01bc_ctrl were build. But smb2 Tools like smb2_eetemp are missing. In our User Manuals we have examples with the smb2 Tools. It is inconsistent to show the customer the tools but they are not available to the customer.

dpfeuffer commented 3 years ago

The cause of the problem is the MDISforLinux/BUILD/MDIS/TPL/DSC/Makefile.sc31.tpl file (and it seems to me, that other Makefile.sc.tpl files are also affected). This makefiles add the SMB2 driver but not the SMB2 tools. I'm wondering if the Makefile.tpl files are still required. The information which SW to build should be taken from the driver package description files (xml).

dpfeuffer commented 3 years ago

@mlassota Please check the described behavior and how to improve the scan functionality by using xml instead of Makefile*.tpl files. All non internal SMB2 tools shall be available when the SMB2 driver will be installed.

mlassota commented 3 years ago

Fixed adding SMB2 tools.

dpfeuffer commented 3 years ago

I reopen this issue, because we run today into the following problem with 13MD05-90_02_03: When we add just the smb2 tools manually from the MDISWIZ, without adding the necessary smb2 libs, we get build errors. IMHO is your commit to fix this issue are not complete, because it adds no SMB2 libs. Please try to reproduce these build errors by adding the ALL_LL_TOOLS = \ from your commit (changes in Makefile.sc31.tpl). Then add the missing SMB2 API libs (reported from the build errors) and fix it.

mlassota commented 3 years ago

Fixed