search

MEONMedical / Log4Qt

Log4Qt - Logging for the Qt cross-platform application framework
Apache License 2.0
589 stars 236 forks source link

Library is not thread-safe with MSVC 2013 #11

Closed Markus43 closed 7 years ago

Markus43 commented 7 years ago

Since this commit Log4Qt heavily uses C++11's magic statics feature.

Since CI is testing the library with MSVC 2013, I was assuming that the C++11 features of this compiler are sufficient for using Log4Qt. However, this is not true: MSVC 2013 does not support "Magic statics", see https://msdn.microsoft.com/en-us/library/hh567368%28v=vs.120%29.aspx .

andibacher commented 7 years ago

Thank for your observation, the unit test propably do not cover the thread safty. We were not aware that msvc 2013 dies not support the feature "Magic statics" which we used in some part for thread safty. I added the minimum required compiler in tne readme and removed the CI testing for MSVC 2013. We are not going to fix this for compiler not supporting the magic status features, because the goal of this fork is to provide a more modern implementation of the original log4t.