search

MEONMedical / Log4Qt

Log4Qt - Logging for the Qt cross-platform application framework
Apache License 2.0
589 stars 236 forks source link

Compile with QT_USE_QSTRINGBUILDER #14

Closed chehrlic closed 7 years ago

chehrlic commented 7 years ago

Add 'QT_USE_QSTRINGBUILDER' for more efficient QString concatenation operations - see http://doc.qt.io/qt-5/qstring.html#more-efficient-string-construction

andibacher commented 7 years ago

Thank you for your merge request. Merged two of them. For this stringbuilder merge requst I am not sure if the global approach QT_USE_QSTRINGBUILDER is the right, i would prefer explicit using the StringBuild with %.

chehrlic commented 7 years ago

What do you think are the problems with this define? I'm using it in my projects since ages and found nothing except some explicit QString() casts