MEONMedical / Log4Qt

Log4Qt - Logging for the Qt cross-platform application framework
Apache License 2.0
589 stars 235 forks source link

removeAppender must cause deadlock #77

Closed lyqdy closed 3 months ago

lyqdy commented 1 year ago

void AppenderAttachable::removeAppender(const QString &name) { QWriteLocker locker(&mAppenderGuard); // it must be removed! AppenderSharedPtr pAppender = appender(name); if (pAppender) removeAppender(pAppender); }

andibacher commented 3 months ago

As the mutex allows recursive lock it should not lock. But removed unnecessary lock.