MER-C / wiki-java

A MediaWiki bot framework in Java
GNU Affero General Public License v3.0
66 stars 58 forks source link

Guard against null pointers in `Wiki.exists` #193

Closed PeterBowman closed 1 year ago

PeterBowman commented 1 year ago

Wiki.getPageInfo returns null for invalid titles.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 :tada:

Comparison is base (f6e10fb) 38.30% compared to head (9bc904b) 38.38%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #193 +/- ## ============================================ + Coverage 38.30% 38.38% +0.07% - Complexity 741 746 +5 ============================================ Files 38 38 Lines 6472 6472 Branches 1144 1145 +1 ============================================ + Hits 2479 2484 +5 + Misses 3797 3793 -4 + Partials 196 195 -1 ``` | [Impacted Files](https://codecov.io/gh/MER-C/wiki-java/pull/193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/org/wikipedia/Wiki.java](https://codecov.io/gh/MER-C/wiki-java/pull/193?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL29yZy93aWtpcGVkaWEvV2lraS5qYXZh) | `54.04% <100.00%> (+0.14%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/MER-C/wiki-java/pull/193/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.