search

MESAHub / mesa-contrib

Contributed procedures for use with Modules for Experiments in Stellar Astrophysics (MESA)
12 stars 3 forks source link

`enhanced_Tayler_Spruit` in MESA `r21.12.1-rc1` #4

Closed warrickball closed 2 years ago

warrickball commented 2 years ago

enhanced_Tayler_Spruit currently doesn't compile with the new MESA release candidate r12.12.1-rc1 because the call signature for kap_get_elect_cond_opacity called in sige2 has changed from

      subroutine kap_get_elect_cond_opacity( &
            zbar, logRho, logT, &
            kap, dlnkap_dlnRho, dlnkap_dlnT, ierr)

to

      subroutine kap_get_elect_cond_opacity( &
            handle, zbar, logRho, logT, &
            kap, dlnkap_dlnRho, dlnkap_dlnT, ierr)

i.e., the first argument is now a handle to the opacity tables. The fix is presumably to pass s% kap_handle through diffmag to sige2 but I thought I'd leave it in your hands as to how exactly you'd like to do that. (I also noticed that the only reason the opacity handle is passed is to pick up whether or not to use the Blouin et al. conductive opacities.)

warrickball commented 2 years ago

Wait! I've made a mess by testing the wrong branch against the release candidate. I'll try to clear this up tonight.

warrickball commented 2 years ago

False alarm. This is already fixed on main.