MESAHub / mesa

Modules for Experiments in Stellar Astrophysics
http://mesastar.org
GNU Lesser General Public License v2.1
138 stars 38 forks source link

Running log of documentation errors/typos/out-of-date parameter names found at MESA Summer School 2024 #658

Closed mjoyceGR closed 3 months ago

mjoyceGR commented 3 months ago

docs version 24.03.1 in tutorial for modifying run_star_extras:

Typos in the directions for adding history column: vals(2) = safe_log10_cr(s% R(i) / rsol) ! in solar radii should be vals(2) = safe_log10_cr(s% R(i) / rsol) ! in solar radii

When adding an extra profile column vals(k,1) = s% Pgas(k)/s% P(k) Should be vals(k,1) = s% Pgas(k)/s% Peos(k)

wrong path for the star_ptr information, it should be $MESA_DIR/star_data/public/star_data_*.inc
as mentioned in the star info section earlier

with thanks to @BucheleL, @courtcraw

maja-jablonska commented 3 months ago

safe_log10_cr also didn't work for me - either safe_log10 or log10 did.

mjoyceGR commented 3 months ago

brilliant, thank you! 10 MESA Summer School points*

*no cash value

BucheleL commented 3 months ago

At the end of the paragraph after "Add Stopping Condition", the "when to stop" section in controls.defaults is at line 940 not 230.

BucheleL commented 3 months ago

For Zbase in kap controls, it isn't clear what happens with the default value of -1 (does MESA then default to using initial_z?)

gautam-404 commented 3 months ago

The docs do not explicitly define the conditions underlying the stop_at_phase_* stopping controls

JMombarg commented 3 months ago

The explanation of near_zams_relax_omega mentions that the working definition of ZAMS is set by Lnuc_div_L_upper_limit. This should be Lnuc_div_L_zams_limit, as Lnuc_div_L_upper_limit is used to terminate the run.

Debraheem commented 3 months ago

wrong path for the star_ptr information, it should be $MESA_DIR/star_data/public/star_data_*.inc as mentioned in the star info section earlier

I can't find the location of the wrong path, perhaps this has already been fixed!

BucheleL commented 3 months ago

@Debraheem I still see old path in line 179 of extending_mesa.rst in #655.