search

MESAHub / mesa

Modules for Experiments in Stellar Astrophysics
http://mesastar.org
GNU Lesser General Public License v2.1
146 stars 39 forks source link

Make `num` comply (mostly) with Fortran 2008 standard #702

Closed warrickball closed 3 months ago

warrickball commented 3 months ago

This is the continuation of @VincentVanlaer's PR #696 (thanks Vincent!), which already made num/test comply with the Fortran 2008 standard. The rest of num is now compiled with a Fortran 2008 flag so the aim is to reduce the number of warnings before merging this into main.

We should make sure we can still build with ifort before merging.

pmocz commented 3 months ago

Are we good to merge this?

warrickball commented 3 months ago

I think so? I'm not sure if we want to wait until after the release. I personally don't mind but wouldn't mind at least another dev chipping in.

pmocz commented 3 months ago

I think so? I'm not sure if we want to wait until after the release. I personally don't mind but wouldn't mind at least another dev chipping in.

Probably best to merge this in right after release actually, since we'd like to get the release out very soon and even though we tested this branch it doesn't add too much to users (yet, without the other successive PRs which should be left for after the release)

pmocz commented 3 months ago

Merging now that we already have the 24.08.1 release branch