search

MESAHub / mesa

Modules for Experiments in Stellar Astrophysics
http://mesastar.org
GNU Lesser General Public License v2.1
138 stars 38 forks source link

mtx: drop quad precision support #712

Open VincentVanlaer opened 1 month ago

VincentVanlaer commented 1 month ago

I noticed some warnings in the mtx module which came from the quad precision code. After some messing around with the code, I noticed that none of it was currently in use. Therefore, I removed all of the quad precision code. If the dev team wants to keep this around for future use, feel free to close :)

warrickball commented 6 days ago

I think we might need @orlox to weigh in here. I recall the discussion of quad-precision sums for advanced burning in Sec. 5 of MESA III but I'm not sure if that's still used nor if it warranted bundling all the quad-precision linear algebra. I noticed MESA II mentions quad-precision linear algebra in Sec. B.6, when discussing the separate solution of the angular momentum profile. So maybe these were once used in the rotation (and maybe binary?) routines but aren't any more.

fxt44 commented 4 days ago

quad precision linear algebra is mostly a leftover from the mesa III experiments. for nuclear burning, only summing the contributions to each isotope in quad is absolutely necessary. quad jacobians, hence quad linear algebra, turned out to not be as important (but we did check!)

VincentVanlaer commented 3 days ago

Rebased on main