mtx: don't vendor lapack

MESAHub / mesa

Modules for Experiments in Stellar Astrophysics

http://mesastar.org

GNU Lesser General Public License v2.1

138 stars 38 forks source link

mtx: don't vendor lapack #723

Closed VincentVanlaer closed 2 weeks ago

VincentVanlaer commented 1 month ago

It is only used for non-sdk builds, and other required libraries (such as HDF5) are not included for non-sdk builds as well. Furthermore, this prevents the vendored version from being out of date with the SDK version.

pmocz commented 1 month ago

This makes sense to me. Just have the sdk take care of lapack, since that's what we test and support, and remove 3rd party source code from Mesa. We should merge this PR if others agree

warrickball commented 1 month ago

I agree in principle but this will break my ifort build until I switch it over to using the system LAPACK, which I should do anyway but might not have much time for ~2-3 weeks.

warrickball commented 1 month ago

I think I managed to switch, though to using the Intel Math Kernel Library™ (MKL), which appears to break bit-for-bit in the mtx, net and num tests, but the results look okay. I messed up my first run, which has contaminated TestHub with apparently mixed failures but I'll have a close look for discrepancies the next time I test main.

But I think the bundled BLAS/LAPACK can go.