Closed vitalJP closed 4 years ago
These are only example in ISA 95 Part 2. They should not be hard coded in B2MML. Recommend reject.
Those are still just examples, but its ok to leave this change in place, and let people use the "OtherValue" where needed.
Issue closed.
I see this is committed now to the master. Thanks. 1 comment though, the code could use some clean up. there are unnecessary empty comments left throughout the entire common.xsd
Yes, there was a mixture of tabs and spaces, so the indentation was messed up on the one I pulled grit ETPartners. Some of the editing was previulsy done with tabs set to 2 spaces, some with tabs to 4 spaces, and some with just spaces. I fixed a lot of them on the MESA version, but did not get all of them.
I left the because they serve to help make the schema more readable using something like Notepad++. It doesn’t hurt to have them there.
Dennis
Dennis Brandl
208 Townsend Ct, Suite 200
Cary, NC 27518-8319, USA
+1-919-852-5322 (Office)
+1-919-656-2205 (Cell)
+1-832-201-0554 (Fax)
http://www.brlconsulting.com/ www.brlconsulting.com
<mailto:DnBrandl@BRLConsulting.com> DnBrandl@BRLConsulting.com
From: gerardmoloneyetpartners notifications@github.com Sent: Monday, September 7, 2020 1:03 AM To: MESAInternational/B2MML-BatchML B2MML-BatchML@noreply.github.com Cc: Dennis Brandl dnbrandl@brlconsulting.com; State change state_change@noreply.github.com Subject: Re: [MESAInternational/B2MML-BatchML] Add XSD ComplexType name "SpatialDefinitionFormatType" to Common Schema as enumerations to align to 950002, Clause 5.2 (#50)
I see this is committed now to the master. Thanks. 1 comment though, the code could use some clean up. there are unnecessary empty comments left throughout the entire common.xsd
https://user-images.githubusercontent.com/54049079/92350066-6d10b580-f10a-11ea-9999-afaa02e0f3dd.PNG
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/MESAInternational/B2MML-BatchML/issues/50#issuecomment-688037061 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AEBIXAQ4VJUXBA3Q3LYIHPTSERSRTANCNFSM4I7HLH4Q . https://github.com/notifications/beacon/AEBIXARMR6VCGUKS5L4WTDTSERSRTA5CNFSM4I7HLH42YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFEBJZRI.gif
Background In Common Schema, for the previous Issue that changed complexType name="SpatialDefinitionType" by changing "Format" element from IdentifierType to "SpatialDefinitionFormatType"), a list of enumerations is added to comply and align to updated ISA-950002, Clause 5.2 Spatial definitions, Table 19 - Attributes of spatial definition and Example 4.
Supporting Documents 950002 Clause 5.2 Spatial definitions, Table 19 - Attributes of spatial definition Example 4. List of Possible Defined Values.
Impacted Types and Solution B2MML-Common.xsd, "SpatialDefinitionType"
ADD: See below for complete xsd. complexType name="SpatialDefnitionFormatType" complexType name="SpatialDefnitionFormat1Type"
Example 4 has the 8 common format types that are used across 95% of market as spatial data identification type acronyms. These include WKT, WKB, GML, KML, GPX, GeoJSON, SVG, and other. The documentation of these types are listed below in the XSD schema complex type.
The Spatial Format Enumeration Data Types are as follows: