search

MESAInternational / B2MML-BatchML

B2MML is an XML implementation of the ANSI/ISA-95, Enterprise-Control System Integration, family of standards (ISA-95), known internationally as IEC/ISO 62264. B2MML consists of a set of XML schemas written using the World Wide Web Consortium's XML Schema language (XSD) that implement the data models in the ISA-95 standard.
Other
93 stars 45 forks source link

The enumeration "ResourceLocationType1Type" repeats the "Equipment" field #75

Closed BigVulcanDeal closed 1 year ago

BigVulcanDeal commented 2 years ago

In B2MML-Common.xsd, the ResourceLocationType1Type repeats the field "Equipment

<xsd:complexType name="ResourceLocationType1Type">
    <xsd:simpleContent>
        <xsd:restriction base="CodeType">
            <xsd:enumeration value="Operational Location ID"/>
            <xsd:enumeration value="Operational Location"/>
            <xsd:enumeration value="Equipment"/>
            <xsd:enumeration value="Person"/>
            <xsd:enumeration value="Equipment"/>
            <xsd:enumeration value="Physical Asset"/>
            <xsd:enumeration value="Description"/>
            <xsd:enumeration value="Other"/>
        </xsd:restriction>
    </xsd:simpleContent>
</xsd:complexType>
BigVulcanDeal commented 2 years ago

After looking a little closer, I assume that one of these "Equipment" entries should be something else .. "Material" comes to mind ..

gerardmoloneyetpartners commented 1 year ago

Actually, if we read the documentation a few lines down, it explains the enumeration list. image

In all likelihood, the list was probably copied from somewhere, and instead of deleting the 'material' its been changed to 'equipment' and introduced the duplicate in the list.

I vote for deleting line 1572 to remove the duplicate. There is no need to reference something being stored in, or required to move inside a MaterialLot. So a Material reference in the ResourceLocationType1Type is not required, as per the documentation.

Dennis-Brandl commented 1 year ago

I will remove.

Dennis-Brandl commented 1 year ago

Fixed in latest merge with main