MESH-Research / boss-child

0 stars 3 forks source link

Verify / fix sub-pages for theme refresh #142

Closed mikethicke closed 2 years ago

mikethicke commented 2 years ago

Verify that sub-pages on the main site function correctly in the refreshed theme.

Correct any minor issues that come up as part of this issue. Larger problems should be split into separate issues.

kfitz commented 2 years ago

Top-level sub-pages look great, though Sites now looks unbalanced without a right sidebar. I suggest we add one.

Also: individual group page layout/CSS may need some tweaking to deal with the fallout from a cover image that is narrower than the width of the browser window (result: teal background peeking out on both sides).

mikethicke commented 2 years ago

Cover images for groups have been set to stretch to fill the full width of the page.

@kfitz --- what would go in a sidebar for sites?

kfitz commented 2 years ago

I'm going to toss this question to @babaklar and @bjr70. My own sense is that there are some what-for questions that we might answer in the Sites sidebar in the same we we do in the Groups sidebar. Alternately, we could have a list of recent posts (like the recent member activity on Members), but I wouldn't want that to get filled up with a bunch of "Hello World" posts and no real content.

babaklar commented 2 years ago

I like the idea of the what-for questions--it's consistent with groups and a nice place for some onboarding pointers.

kfitz commented 2 years ago

Am I correct that all that remains here is the sidebar for the Sites listing? Is this text I can help generate, or is it underway?

bjr70 commented 2 years ago

I haven't yet looked at this. One thing we need to figure out is if we can edit the template for it. Right now it's on the default template, and we may be able to copy the CORE or group template to create one with a similar sidebar. @babaklar have you thought about text?

babaklar commented 2 years ago

I haven't started writing the text for this yet, but I will make time for it in the next couple days. I'm still thinking something along the lines of what-for/FAQs. I'll send a draft of the text on Wednesday or Thursday, and keep me updated on what it's looking like with the template.

babaklar commented 2 years ago

Here's my first draft of the sites sidebar: https://hcommons-2.dev/sites/. Any comments/suggestions/edits would be appreciated!

bjr70 commented 2 years ago

I think it's good @babaklar.

mikethicke commented 2 years ago

Sidebar looks good to me. Can we close this?

babaklar commented 2 years ago

Yep, this is all set.

bjr70 commented 2 years ago

Sidebar is good. The page headings on both hcommons-2.dev and hastac.hcommons-staging.org still need to be fixed. See this issue: Commons#426.

bjr70 commented 2 years ago

I think this one can be closed as long as both sites' headers are handled on #426.