Closed wreality closed 3 weeks ago
Thanks Brian, this all makes sense.
My main concern is getting the images pushed to ECR so Dimitris can use them for the production deployment. How close are we on that?
@mikethicke very. The frontend container should be good to go and when I can chat with Ian about the app container error on Monday I'm sure it'll be a quick fix. (If not, the container itself isn't really any different from the original so we should be able to orchestrate and stand everything up one way or another by tomorrow) (bold proclamations, aside)
@mikethicke @tzouris @monotasker
OK, so I made a pretty aggressive refactor on the repo to hopefully make deployment/build a little less obfuscated (totally realize these were defaults from invenio).
Major points:
kcworks
,kcworks-frontend
) into their own directory and structure the directories to better match the final resting place of the files in the container (make it easier to understand what to expect where inside the running container)kcworks-frontend
as the loadbalancer will terminate SSL.dev
docker compose to justdocker-compose.yml
for DX.Remaining:
I /think/ in my extremely humble opinion that most of these are improvements and not just preferences, BUT I've not been the ones in the weeds, so please know I won't take offence if something needs tweaks.