Migrated users in collections appearing with bad names

MESH-Research / knowledge-commons-works

The next-generation research repository for the Knowledge Commons (formerly Humanities Commons)

https://hcommons.org

MIT License

4 stars 0 forks source link

Migrated users in collections appearing with bad names #583

Closed bjr70 closed 3 weeks ago

bjr70 commented 1 month ago

Describe the bug Admins is groups are being migrated as things like "knowledge-Commons-zwh" and are not viewable by recognizable name.

Expected behavior Users should be listed by name.

Screenshots

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context Add any other context about the problem here.

monotasker commented 1 month ago

This should be resolved as soon the user has a readable name imported from their KC account. The username has to use that format internally in KCWorks, but it is not displayed if the user has a full readable name. There may be an issue on prod with user profile data not being imported automatically, and so the full names not being available for display. I'll resolve it before launch day.

monotasker commented 1 month ago

2024-08-13 - Found and fixed error in invenio_remote_user_data causing updates to fail 2024-08-13 - Found and fixed logic in invenio_remote_user_data that was resetting preferences to hide users and their emails 2024-08-13 - Added custom logic to SAML account setup to ensure that new accounts created by SAML login are not just confirmed but also activated

2024-08-13 - Found problem with user data only updating on login (sessions can now be very long) 2024-08-13 - Found indexing problem with custom profile fields that aren't simple strings (profile mapping in invenio_communities is dynamic but sets "keyword" data type)

monotasker commented 1 month ago

2024-08-13 - Encountering weird situation with hctester80@gmail.com where saml login returns different username than the one actually used for that login in kc (kelly4200 vs hctester80)

Same situation with my test account (iscott returned in SAML response from comanage vs ianscott username in KC)

username value being taken from SAML entity:

<ns1:Attribute FriendlyName="employeeNumber"
                     Name="urn:oid:2.16.840.1.113730.3.1.3"
                     NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:unspecified"
>
<ns1:AttributeValue xmlns:xs="http://www.w3.org/2001/XMLSchema"
                                  xsi:type="xs:string"
 >
    iscott
</ns1:AttributeValue>
</ns1:Attribute>

Solved: turned out to be the use of dev comanage db to handle dev and staging WP instances

monotasker commented 4 weeks ago

2024-08-14 - Added a cli utility to manually update remote user data to allow for testing 2024-08-14 - Confirmed that user names display correctly when the fullname data is present (from remote)

working on fixing indexing problem

monotasker commented 3 weeks ago

2024-08-16 Fixed indexing problem