Closed veni-vidi-vici-dormivi closed 1 month ago
Hm why are we not getting a codecov report here?
Hm why are we not getting a codecov report here?
The log gives a hint: https://github.com/MESMER-group/mesmer/pull/430/checks#step:8:55
Can't say that I understand it, though ðŸ¤. I thought codecov was moving away from tokens, but they seem to recommend it again. Let me check what xarray does... Also why only this PR and why consistently?
Ah I think it's here: https://docs.codecov.com/docs/codecov-uploader#supporting-token-less-uploads-for-forks-of-open-source-repos-using-codecov (the last paragraph)
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.79%. Comparing base (
9b0b76b
) to head (c21905f
). Report is 49 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ah now also the Codecov report's here :)
We could add another test, but it is not really code related but rather of scientific nature: transform skewed data and test if it is actually less skewed afterwards. What do you think @mathause ?
You ignored two of my comments, which I think are still valid.
Sorry, hadn't pushed them yet.
Okay this got messy but now it's ready to merge.
So these fail because the bounds and first guess are not good. Hopefully, after merging #429 and #427 in here, the tests pass. They do locally with the new bounds and fg.