MESMER-group / mesmer

spatially-resolved ESM-specific multi-scenario initial-condition ensemble emulator
https://mesmer-emulator.readthedocs.io/en/latest/
GNU General Public License v3.0
23 stars 17 forks source link

fix passing time dimension instead of dataarray in upsampling #435

Closed veni-vidi-vici-dormivi closed 4 months ago

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.07%. Comparing base (9b0b76b) to head (df93336). Report is 28 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #435 +/- ## ========================================== - Coverage 87.90% 82.07% -5.84% ========================================== Files 40 44 +4 Lines 1745 1936 +191 ========================================== + Hits 1534 1589 +55 - Misses 211 347 +136 ``` | [Flag](https://app.codecov.io/gh/MESMER-group/mesmer/pull/435/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/MESMER-group/mesmer/pull/435/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group) | `82.07% <100.00%> (-5.84%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

veni-vidi-vici-dormivi commented 5 months ago

You mean implementing a keyword argument in upsample_yearly_data and fit_to_bic_xr and passing the monthly_data data array (potentially including tas) into upsampling? I agree that a flexible time dimension would be better.

mathause commented 5 months ago

I thought to just write it out for now an let the other be a long term goal

veni-vidi-vici-dormivi commented 5 months ago

let the other be a long term goal

Whoopsie too late. What do you think about this? Then I would change the PR title to "Make time dim explicit in upsampling yearly data".