MESMER-group / mesmer

spatially-resolved ESM-specific multi-scenario initial-condition ensemble emulator
https://mesmer-emulator.readthedocs.io/en/latest/
GNU General Public License v3.0
22 stars 15 forks source link

remove jac=rosen_der for from power transformer optimization #447

Closed veni-vidi-vici-dormivi closed 1 month ago

veni-vidi-vici-dormivi commented 1 month ago

Using rosen_der for the Jacobian in the power transformer optimization lead to instabilities in the fit, see discussion in #440

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.66%. Comparing base (9b0b76b) to head (3693b78). Report is 39 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #447 +/- ## ========================================== - Coverage 87.90% 83.66% -4.25% ========================================== Files 40 43 +3 Lines 1745 1928 +183 ========================================== + Hits 1534 1613 +79 - Misses 211 315 +104 ``` | [Flag](https://app.codecov.io/gh/MESMER-group/mesmer/pull/447/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/MESMER-group/mesmer/pull/447/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group) | `83.66% <100.00%> (-4.25%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=MESMER-group#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.